[webkit-reviews] review requested: [Bug 127086] CStack: Fix 32-bit C loop LLINT. : [Attachment 221343] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 16 01:03:53 PST 2014


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 127086: CStack: Fix 32-bit C loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=127086

Attachment 221343: the patch.
https://bugs.webkit.org/attachment.cgi?id=221343&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
This patch builds and passes run-javascriptcore-tests --debug --32-bit --cloop
--no-jsc-stress.  This is the minimum patch that will build and run the 32-bit
C loop LLINT.  Since the C loop is based on ARM, this patch also fixes part of
the ARMv7 LLINT implementation.  There is still more to do for ARM (e.g.
alignment issues) but I didn’t want to overlap with the work in Michael’s
patch.	There is still necessarily some minimal overlap with Michael’s patch. 
I’ll rebase this patch after Michael’s 32-bit patch is finalized.


More information about the webkit-reviews mailing list