[webkit-reviews] review requested: [Bug 99683] JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN) : [Attachment 221336] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 99683: JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=99683

Attachment 221336: Patch
https://bugs.webkit.org/attachment.cgi?id=221336&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
(In reply to comment #3)
> As of 2.2.3, we still needed to do the following changes:
>
>     # https://bugs.webkit.org/show_bug.cgi?id=99683
>     reinplace "s:PLATFORM(MAC):OS(DARWIN):g" \
>	  ${worksrcpath}/Source/JavaScriptCore/heap/VTableSpectrum.cpp \
>	  ${worksrcpath}/Source/JavaScriptCore/jit/ThunkGenerators.cpp \
>	  ${worksrcpath}/Source/JavaScriptCore/tools/CodeProfile.cpp

VTableSpectrum.cpp no longer exists, but else it's fine.

Here's the updated patch.