[webkit-reviews] review granted: [Bug 127080] Move user agent code to WebCore and unify some code between OS X and iOS : [Attachment 221327] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 127080: Move user agent code to WebCore and unify some code between OS X
and iOS
https://bugs.webkit.org/show_bug.cgi?id=127080

Attachment 221327: Patch
https://bugs.webkit.org/attachment.cgi?id=221327&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221327&action=review


r=me!

> Source/WebKit/mac/WebView/WebView.mm:678
> -    NSString *fullVersion = [[NSBundle bundleForClass:[WebView class]]
objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey];
> +    NSString *fullVersion = [[NSBundle
bundleForClass:NSClassFromString(@"WKView")]
objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey];

You should keep this calling [WebView class].