[webkit-reviews] review granted: [Bug 126818] Add AVKit fullscreen video interface. : [Attachment 221290] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 126818: Add AVKit fullscreen video interface.
https://bugs.webkit.org/show_bug.cgi?id=126818

Attachment 221290: Patch
https://bugs.webkit.org/attachment.cgi?id=221290&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221290&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:4883
> +	   if (document().settings() && document().settings()->avKitEnabled())
{

This could be replaced with
`document().page()->chrome().client().supportsFullscreenForNode(this)`, but
this can be done in a follow-up patch.

In fact, you could remove the entire #if !PLATFORM(IOS) check, since the
default chromeClient will answer true for HTMLMediaElements.