[webkit-reviews] review granted: [Bug 127025] Create separate progress tracker clients : [Attachment 221220] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 14 18:20:34 PST 2014
Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 127025: Create separate progress tracker clients
https://bugs.webkit.org/show_bug.cgi?id=127025
Attachment 221220: Patch
https://bugs.webkit.org/attachment.cgi?id=221220&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221220&action=review
> Source/WebKit/mac/WebCoreSupport/WebProgressTrackerClient.mm:53
> +#if !PLATFORM(IOS)
> +void WebProgressTrackerClient::willChangeEstimatedProgress()
> +{
> + [m_webView _willChangeValueForKey:_WebEstimatedProgressKey];
> +}
> +
> +void WebProgressTrackerClient::didChangeEstimatedProgress()
> +{
> + [m_webView _didChangeValueForKey:_WebEstimatedProgressKey];
> +}
> +#endif
I'd prefer if we still implemented these functions but just didn't call the
_will/_did on iOS.
More information about the webkit-reviews
mailing list