[webkit-reviews] review granted: [Bug 127002] [Win] Set MSBUILD environment variable to avoid long-lived processes locking log files : [Attachment 221194] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 127002: [Win] Set MSBUILD environment variable to avoid long-lived
processes locking log files
https://bugs.webkit.org/show_bug.cgi?id=127002

Attachment 221194: Patch
https://bugs.webkit.org/attachment.cgi?id=221194&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221194&action=review


r=me

> Tools/Scripts/webkitdirs.pm:1461
> +	   if (!$ENV{'MSBUILDDISABLENODEREUSE'}) {

If it's not set, this may produce a benign (but annoying) error message about
using an undefined value.  This check may be slightly better:

	if (!defined $ENV{'MSBUILDDISABLENODEREUSE'} ||
!$ENV{'MSBUILDDISABLENODEREUSE'}) {