[webkit-reviews] review granted: [Bug 127005] Pack ResourceResponse harder. : [Attachment 221196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 14 13:33:45 PST 2014


Anders Carlsson <andersca at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 127005: Pack ResourceResponse harder.
https://bugs.webkit.org/show_bug.cgi?id=127005

Attachment 221196: Patch
https://bugs.webkit.org/attachment.cgi?id=221196&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221196&action=review


> Source/WebCore/platform/network/ResourceResponseBase.cpp:53
> +    , m_cacheControlMaxAge(0.0)
> +    , m_age(0.0)
> +    , m_date(0.0)
> +    , m_expires(0.0)
> +    , m_lastModified(0.0)

I'd change all these to say 0.

> Source/WebCore/platform/network/ResourceResponseBase.cpp:80
> +    , m_cacheControlMaxAge(0.0)
> +    , m_age(0.0)
> +    , m_date(0.0)
> +    , m_expires(0.0)
> +    , m_lastModified(0.0)

Ditto.


More information about the webkit-reviews mailing list