[webkit-reviews] review granted: [Bug 126915] AX: Modernize AccessibilityChildrenVector loops : [Attachment 221166] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 126915: AX: Modernize AccessibilityChildrenVector loops
https://bugs.webkit.org/show_bug.cgi?id=126915

Attachment 221166: patch
https://bugs.webkit.org/attachment.cgi?id=221166&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221166&action=review


> Source/WebCore/accessibility/AXObjectCache.cpp:127
> +    for (const auto& object : m_objects) {
> +	   AccessibilityObject* axObject = object.value.get();
> +	   detachWrapper(axObject, CacheDestroyed);
> +	   axObject->detach(CacheDestroyed);
> +	   removeAXID(axObject);
>      }

This can just iterate over m_objects.values(), then you don't need the
object.value.get().

> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:87
> +	   auto& siblings = parent->children();

I think this can be const auto&.

> Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:223
> +    auto& listItems = selectElement->listItems();

const auto&.

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:111
> +    auto& childObjects = children();

const auto&.

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:338
> +	   auto& children = child->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityObject.cpp:420
> +    auto& searchChildren = object->isAccessibilityTable() ?
toAccessibilityTable(object)->rows() : object->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3553
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3566
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3580
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3604
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3619
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3636
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3649
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3664
> +    auto& children = this->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityTable.cpp:508
> +	   auto& children = m_rows[rowIndex]->children();

const auto&.

> Source/WebCore/accessibility/AccessibilityTableRow.cpp:120
> +    auto& rowChildren = children();

const auto&.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:350
> +    auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:370
> +    auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1076
> +    auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:82
> +    for (auto& pair : pairs) {

It looks like this can be const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:166
> +    for (auto text : textOrder) {

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:195
> +    for (auto text : textOrder) {

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:221
> +    for (auto text : textOrder) {

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2378
> +	       auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3612
> +    auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3638
> +	   auto& children = m_object->children();

const auto&.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3670
> +	   auto& children = m_object->children();

const auto&.