[webkit-reviews] review granted: [Bug 126978] [CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index : [Attachment 221146] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 14 06:14:43 PST 2014
Antti Koivisto <koivisto at iki.fi> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 126978: [CSSRegions] The list of fixed positioned layers in named flows
should be sorted by z-index
https://bugs.webkit.org/show_bug.cgi?id=126978
Attachment 221146: Patch
https://bugs.webkit.org/attachment.cgi?id=221146&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review
> Source/WebCore/rendering/RenderLayer.cpp:4062
>
renderer().view().flowThreadController().collectFixedPositionedLayers(fixedLaye
rs);
Maybe call it collectSortedFixedPositionedLayers or similar?
We nowadays prefer collection functions to return the vector normally instead
of passing an argument since rvalue references make it copy-free.
More information about the webkit-reviews
mailing list