[webkit-reviews] review requested: [Bug 126133] Make CachedSVGDocument independent of CSS Filters : [Attachment 221139] Patch for landing

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 126133: Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133

Attachment 221139: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=221139&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This patch uses a different approach. CachedSVGDocumentReference is now
responsible for requesting the SVG document.

Note to the original code:

-	     if
(SVGURIReference::isExternalURIReference(svgDocumentValue->url(),
m_state.document())) {
-		 if (!svgDocumentValue->loadRequested())
-		     m_state.pendingSVGDocuments().set(operation.get(),
svgDocumentValue);
-		 else if (svgDocumentValue->cachedSVGDocument())
-		     operation->setCachedSVGDocumentReference(adoptPtr(new
CachedSVGDocumentReference(svgDocumentValue->cachedSVGDocument())));
-	     }

I wrote a bunch of test cases and the else if clause was never called.
Independent if element style, document style... setting filter for a collection
of elements.