[webkit-reviews] review granted: [Bug 125224] [CSS Shapes] Shape images are now <image> types, not just URIs : [Attachment 220566] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 125224: [CSS Shapes] Shape images are now <image> types, not just URIs
https://bugs.webkit.org/show_bug.cgi?id=125224

Attachment 220566: Patch
https://bugs.webkit.org/attachment.cgi?id=220566&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220566&action=review


r=me

> LayoutTests/fast/shapes/shape-outside-floats/shape-outside-image-set.html:7
> +	   /* The shape-outisde image's width is smaller than the float's width
(120 < 150) to make it

Typo, shape-outside.

> Source/WebCore/rendering/shapes/Shape.cpp:256
> -    ASSERT(styleImage && styleImage->isCachedImage() &&
styleImage->cachedImage() && styleImage->cachedImage()->image());
> +    ASSERT(styleImage && styleImage->cachedImage() &&
styleImage->cachedImage()->hasImage());

These should be broken into separate assertions so you can immediately tell
what went wrong.
It'd also be nicer if 'styleImage' were a reference, since we don't support it
being null.