[webkit-reviews] review granted: [Bug 126790] CStack: Fix 64-bit C Loop LLINT : [Attachment 220913] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 126790: CStack: Fix 64-bit C Loop LLINT
https://bugs.webkit.org/show_bug.cgi?id=126790

Attachment 220913: the patch.
https://bugs.webkit.org/attachment.cgi?id=220913&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220913&action=review


r=me

> Source/JavaScriptCore/llint/LLIntOpcode.h:48
> +    macro(llint_synthesized_label_1, 1) \
> +    macro(llint_synthesized_label_2, 1) \
> +    macro(llint_synthesized_label_3, 1) \
> +    macro(llint_synthesized_label_4, 1) \
> +    macro(llint_synthesized_label_5, 1) \
> +    macro(llint_synthesized_label_6, 1) \
> +    macro(llint_synthesized_label_7, 1) \

Let's call these "llint_cloop_did_return_from_js_N".

> Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:93
> +#if 0

Let's give this a name, like ENABLE_OPCODE_TRACING.

> Source/JavaScriptCore/offlineasm/asm.rb:48
> +	   @numSynthesizedGlobalLabels = 0

Let's call this "didReturnFromJSLabelCounter", and move into cloop.rb's
Instruction class, using @@ syntax for a per-class variable.

> Source/JavaScriptCore/offlineasm/asm.rb:228
> +    def numSynthesizedGlobalLabels()
> +	   @numSynthesizedGlobalLabels
> +    end
> +    def incNumSynthesizedGlobalLabels()
> +	   @numSynthesizedGlobalLabels += 1
> +    end

See above renames.