[webkit-reviews] review granted: [Bug 126936] [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build : [Attachment 221083] [iOS] Exclude shims and PluginProcess.app from the WebKit2 build

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 126936: [iOS] Exclude Shims and PluginProcess.app from the WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=126936

Attachment 221083: [iOS] Exclude shims and PluginProcess.app from the WebKit2
build
https://bugs.webkit.org/attachment.cgi?id=221083&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221083&action=review


Looks sane to me. Feel free to ask a build system expert for a more thorough
review.

> Source/WebKit2/Configurations/Shim.xcconfig:33
> +OTHER_LDFLAGS_PluginProcessShim = -framework AppKit -framework Carbon
-framework QuartzCore;
> +OTHER_LDFLAGS_SecItemShim = -framework Security;
> +OTHER_LDFLAGS_WebProcessShim = -framework CoreServices -framework Security;

I take it you feel that it wouldn't improve readability to include _macosx_ in
the names of these variables.