[webkit-reviews] review denied: [Bug 123532] Implement MemoryPressureHandler for Linux system : [Attachment 217871] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 13 11:44:46 PST 2014
Anders Carlsson <andersca at apple.com> has denied Tomeu Vizoso
<tomeu at tomeuvizoso.net>'s request for review:
Bug 123532: Implement MemoryPressureHandler for Linux system
https://bugs.webkit.org/show_bug.cgi?id=123532
Attachment 217871: Patch
https://bugs.webkit.org/attachment.cgi?id=217871&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217871&action=review
> Source/WebCore/platform/MemoryPressureHandler.cpp:37
> +#include "CSSValuePool.h"
> +#include "FontCache.h"
> +#include "GCController.h"
> +#include "MemoryCache.h"
> +#include "PageCache.h"
> +#include "ScrollingThread.h"
> +#include "StorageThread.h"
> +#include "WorkerThread.h"
This is a blatant layering violation. This should not be included here.
More information about the webkit-reviews
mailing list