[webkit-reviews] review granted: [Bug 126917] Map RootInlineBox to containing region via bit+hashmap. : [Attachment 221062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 13 10:55:30 PST 2014


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 126917: Map RootInlineBox to containing region via bit+hashmap.
https://bugs.webkit.org/show_bug.cgi?id=126917

Attachment 221062: Patch
https://bugs.webkit.org/attachment.cgi?id=221062&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=221062&action=review


> Source/WebCore/rendering/RootInlineBox.cpp:279
>  void RootInlineBox::setContainingRegion(RenderRegion* region)
>  {
>      ASSERT(!isDirty());
>      ASSERT(blockFlow().flowThreadContainingBlock());
> -    m_containingRegion = region;
> +
> +    if (!region && !m_hasContainingRegion)
> +	   return;
> +
> +    if (region)
> +	   containingRegionMap().set(this, region);
> +    else
> +	   containingRegionMap().remove(this);
> +
> +    m_hasContainingRegion = !!region;
>  }

It would be nicer to have setContainingRegion(RenderRegion&) and
clearContainingRegion() separately.


More information about the webkit-reviews mailing list