[webkit-reviews] review denied: [Bug 126702] REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte : [Attachment 221013] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 126702: REGRESSION (r160085): check-webkit-style: utf8' codec can't decode
byte 0x89 in position 0: invalid start byte
https://bugs.webkit.org/show_bug.cgi?id=126702

Attachment 221013: Patch
https://bugs.webkit.org/attachment.cgi?id=221013&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221013&action=review


> Tools/Scripts/webkitpy/common/system/filesystem.py:203
> +    def open_file_for_read(self, path):
> +	   return codecs.open(path, 'r', 'utf8', 'replace')
> +

We shouldn't be adding this one off function with such an ambitious name here.
r-.

I could see open_text_file_for_reading having an optional argument to do this
instead.