[webkit-reviews] review denied: [Bug 104711] Col width is not honored when dynamically updated and it would make table narrower : [Attachment 213155] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 104711: Col width is not honored when dynamically updated and it would make
table narrower
https://bugs.webkit.org/show_bug.cgi?id=104711

Attachment 213155: Patch
https://bugs.webkit.org/attachment.cgi?id=213155&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=213155&action=review


> Source/WebCore/rendering/AutoTableLayout.cpp:85
>		       columnLayout.minLogicalWidth =
max<int>(cell->minPreferredLogicalWidth(), columnLayout.minLogicalWidth);
> +
> +		       Length cellLogicalWidth =
cell->styleOrColLogicalWidth();
> +		       if (cellLogicalWidth.isFixed() &&
cell->style()->logicalWidth().isAuto()) {
> +			   int logicalWidth =
cell->adjustBorderBoxLogicalWidthForBoxSizing(cellLogicalWidth.value());
> +			   if (cellLogicalWidth.value() >
cell->minPreferredLogicalWidth() && cell->maxPreferredLogicalWidth() !=
logicalWidth)
> +			       cell->setPreferredLogicalWidthsDirty(true);
> +		       }

Actually this looks wrong. The code saves minPreferredLogicalWidth to
columnLayout.minLogicalWidth and then marks logical width dirty. 

Also I suspect the invalidation should be done when the col width changes
rather than during recalcColumn (which happens during layout).