[webkit-reviews] review granted: [Bug 126878] LayoutState and subtree layout code should use RenderElement. : [Attachment 221022] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 126878: LayoutState and subtree layout code should use RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=126878

Attachment 221022: Patch
https://bugs.webkit.org/attachment.cgi?id=221022&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=221022&action=review


> Source/WebCore/rendering/RenderElement.cpp:1036
> +    if (!documentBeingDestroyed() && view().frameView().layoutRoot() ==
this) {
> +	   ASSERT_NOT_REACHED();
> +	   // This indicates a failure to layout the child, which is why
> +	   // the layout root is still set to |this|. Make sure to clear it
> +	   // since we are getting destroyed.
> +	   view().frameView().clearLayoutRoot();
> +    }

Wonder if this could just be an assert.