[webkit-reviews] review denied: [Bug 126881] [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser : [Attachment 221021] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 13 03:07:07 PST 2014
Carlos Garcia Campos <cgarcia at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 126881: [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=126881
Attachment 221021: Patch
https://bugs.webkit.org/attachment.cgi?id=221021&action=review
------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221021&action=review
> Tools/MiniBrowser/gtk/BrowserWindow.c:710
> - g_object_add_weak_pointer(G_OBJECT(parent), &window->parentWindow);
> + g_object_add_weak_pointer(G_OBJECT(parent), (gpointer*)
&window->parentWindow);
Add a space between the gpointer and the * and remove the space between the
parentheses and the &
g_object_add_weak_pointer(G_OBJECT(parent), (gpointer *)&window->parentWindow);
More information about the webkit-reviews
mailing list