[webkit-reviews] review denied: [Bug 114964] AX: some images having no label but having other global attributes (like aria-describedby) are treated as presentational : [Attachment 220889] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 114964: AX: some images having no label but having other global attributes
(like aria-describedby) are treated as presentational
https://bugs.webkit.org/show_bug.cgi?id=114964

Attachment 220889: patch
https://bugs.webkit.org/attachment.cgi?id=220889&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220889&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:1664
>	   || hasAttribute(aria_invalidAttr)
>	   || hasAttribute(aria_labelAttr)
>	   || hasAttribute(aria_labelledbyAttr)
> +	   || hasAttribute(aria_describedbyAttr)

I don't really understand how this change fixes the problem, since that check
is already present a few lines above in this return statement.

Current version in my local copy:

bool AccessibilityObject::supportsARIAAttributes() const
{
    // This returns whether the element supports any global ARIA attributes.
    return supportsARIALiveRegion()
	|| supportsARIADragging()
	|| supportsARIADropping()
	|| supportsARIAFlowTo()
	|| supportsARIAOwns()
	|| hasAttribute(aria_atomicAttr)
	|| hasAttribute(aria_busyAttr)
	|| hasAttribute(aria_controlsAttr)
	|| hasAttribute(aria_describedbyAttr)
	|| hasAttribute(aria_disabledAttr)
	|| hasAttribute(aria_haspopupAttr)
	|| hasAttribute(aria_invalidAttr)
	|| hasAttribute(aria_labelAttr)
	|| hasAttribute(aria_labelledbyAttr)
	|| hasAttribute(aria_relevantAttr);
}

Looking at this and seeing that the test case you added is basically the one
mentioned by James in comment #2, it looks to me like the bug is not present
there anymore. Maybe he's using an old version of WebKit?