[webkit-reviews] review granted: [Bug 126854] Reduce use of String::characters : [Attachment 220985] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 12 15:17:24 PST 2014
Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 126854: Reduce use of String::characters
https://bugs.webkit.org/show_bug.cgi?id=126854
Attachment 220985: Patch
https://bugs.webkit.org/attachment.cgi?id=220985&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220985&action=review
> Source/WebCore/editing/CompositeEditCommand.cpp:674
> for (unsigned i = 0; i < text.length(); ++i) {
> - if (!isWhitespace(text.characters()[i]))
> + if (!isWhitespace(text[i]))
> return false;
> }
> -
> return true;
> }
Could this use isAllSpecialCharacters?
More information about the webkit-reviews
mailing list