[webkit-reviews] review granted: [Bug 126832] [WebGL] Error messages for attributes, uniforms, and varyings should use source code symbols, not internal mangled symbols : [Attachment 220963] Revised to help EFL/GTK to build properly

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 126832: [WebGL] Error messages for attributes, uniforms, and varyings
should use source code symbols, not internal mangled symbols
https://bugs.webkit.org/show_bug.cgi?id=126832

Attachment 220963: Revised to help EFL/GTK to build properly
https://bugs.webkit.org/attachment.cgi?id=220963&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220963&action=review


> Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp:63
>      case SH_VARYINGS:
>	   symbolMaxNameLengthType = SH_VARYING_MAX_LENGTH;
> +	   break;

Ouch! :)