[webkit-reviews] review granted: [Bug 126839] REGRESSION(r160806): line-height is not applied when only present in :link style. : [Attachment 220967] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 126839: REGRESSION(r160806): line-height is not applied when only present
in :link style.
https://bugs.webkit.org/show_bug.cgi?id=126839

Attachment 220967: Patch
https://bugs.webkit.org/attachment.cgi?id=220967&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review


> Source/WebCore/css/StyleResolver.cpp:4255
> +	   if (auto value = state.style()->insideLink() == NotInsideLink ?
cssValue[0] : cssValue[SelectorChecker::MatchLink])

cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be
better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue
or similar).