[webkit-reviews] review granted: [Bug 126817] Clean up iterator filter / iterator range code : [Attachment 220938] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 11 11:10:38 PST 2014


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 126817: Clean up iterator filter / iterator range code
https://bugs.webkit.org/show_bug.cgi?id=126817

Attachment 220938: Patch
https://bugs.webkit.org/attachment.cgi?id=220938&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220938&action=review


Shouldn't you add the necessary using declarations as well?

> LayoutTests/ChangeLog:14
> +2014-01-06  Sam Weinig  <sam at webkit.org>
> +
> +	   [JS] Should be able to create a promise by calling the Promise
constructor as a function
> +	   https://bugs.webkit.org/show_bug.cgi?id=126561
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * js/dom/Promise-types-expected.txt:
> +	   * js/dom/Promise-types.html:
> +	   Add test for using calling a Promise constructor as a function.
> +
>  2014-01-10  Commit Queue  <commit-queue at webkit.org>
>  
>	   Unreviewed, rolling out r161702.

Please don't commit this.


More information about the webkit-reviews mailing list