[webkit-reviews] review granted: [Bug 126805] [iOS] Fix GCController::releaseExecutableMemory : [Attachment 220919] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 21:46:13 PST 2014


Sam Weinig <sam at webkit.org> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 126805: [iOS] Fix GCController::releaseExecutableMemory
https://bugs.webkit.org/show_bug.cgi?id=126805

Attachment 220919: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=220919&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220919&action=review


> Source/WebCore/bindings/js/GCController.cpp:37
>  
> +#if PLATFORM(IOS)
> +#include <runtime/VMEntryScope.h>
> +#endif

Seems like while you are here, you might as well make this function not iOS
specific as it seems generally useful (and you can remove the #ifdefs)!


More information about the webkit-reviews mailing list