[webkit-reviews] review granted: [Bug 126289] REGRESSION (r158369): Some pop-up windows open at incorrect size (affects GMail, theblaze.com) : [Attachment 220916] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 18:30:46 PST 2014


Anders Carlsson <andersca at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 126289: REGRESSION (r158369): Some pop-up windows open at incorrect size
(affects GMail, theblaze.com)
https://bugs.webkit.org/show_bug.cgi?id=126289

Attachment 220916: Fix
https://bugs.webkit.org/attachment.cgi?id=220916&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220916&action=review


>
LayoutTests/platform/mac-wk2/fast/dom/Window/mozilla-focus-blur-expected.txt:8
> -PASS: The focus should not have been changed!
> -PASS: The focus should not have been changed!
> -PASS: The focus should not have been changed with
URL=data:text/html,<script>opener.focus();opener.postMessage("", "*");</script>

> -PASS: The focus should not have been changed with
URL=data:text/html,<script>blur();opener.postMessage("", "*");</script>
> +FAIL: The focus should not have been changed!
> +FAIL: The focus should not have been changed!
> +FAIL: The focus should not have been changed with
URL=data:text/html,<script>opener.focus();opener.postMessage("", "*");</script>

> +FAIL: The focus should not have been changed with
URL=data:text/html,<script>blur();opener.postMessage("", "*");</script>

I think it's better if we skip this test instead of landing new results.


More information about the webkit-reviews mailing list