[webkit-reviews] review granted: [Bug 126792] Fix CharsetData.cpp build for iOS : [Attachment 220905] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 126792: Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792

Attachment 220905: Patch
https://bugs.webkit.org/attachment.cgi?id=220905&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220905&action=review


r=me

> Source/WebCore/DerivedSources.make:1194
> +ifeq ($(WTF_PLATFORM_IOS),1)
> +
> +CharsetData.cpp : platform/text/mac/make-charset-table.pl
platform/text/mac/character-sets.txt platform/text/mac/ios-encodings.txt
> +	perl $^ kTextEncoding > $@
> +
> +else
> +
>  CharsetData.cpp : platform/text/mac/make-charset-table.pl
platform/text/mac/character-sets.txt platform/text/mac/mac-encodings.txt
>	perl $^ kTextEncoding > $@
>  
> +endif # WTF_PLATFORM_IOS

Can we avoid some of the duplication by pulling the path to the encodings file
in to a variable instead?