[webkit-reviews] review granted: [Bug 126674] CSS word-spacing property does not obey percentages : [Attachment 220878] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 126674: CSS word-spacing property does not obey percentages
https://bugs.webkit.org/show_bug.cgi?id=126674

Attachment 220878: Patch
https://bugs.webkit.org/attachment.cgi?id=220878&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220878&action=review


> Source/WebCore/rendering/RenderText.cpp:686
>      const Font& f = style.font(); // FIXME: This ignores first-line.
> -    float wordSpacing = style.wordSpacing();
> +    float wordSpacing = f.wordSpacing();

Please rename "f" to something longer.

> Source/WebCore/rendering/SimpleLineLayout.cpp:143
> +    if (style.wordSpacing().getFloatValue() || style.letterSpacing())

!isZero()?

> LayoutTests/ChangeLog:23
> +	   * platform/mac/css1/text_properties/word_spacing-expected.png:

You should figure out why this doesn't have a mock scrollbar.