[webkit-reviews] review granted: [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase : [Attachment 220818] next try

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has granted Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 108184: ASSERT(time.isFinite()) in
SVGSMILElement::createInstanceTimesFromSyncbase
https://bugs.webkit.org/show_bug.cgi?id=108184

Attachment 220818: next try
https://bugs.webkit.org/attachment.cgi?id=220818&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
Thanks for updating this. I think your new approach looks good.

Not required, but it would be nice to add this testcase so we don't
accidentally break this in the future:
<rect width="100" height="100" fill="green">
  <animate id="fri" attributeName="x" begin="0s; fri.end + 3s" from="0"
to="400" dur="5s"/>
</rect>
(you would need to clean this up and format it like the other animation tests)