[webkit-reviews] review denied: [Bug 119513] [WebGL] compileShader map iterator validation : [Attachment 208172] map iterator validation

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 119513: [WebGL] compileShader map iterator validation
https://bugs.webkit.org/show_bug.cgi?id=119513

Attachment 208172: map iterator validation
https://bugs.webkit.org/attachment.cgi?id=208172&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
This patch isn't necessary (though it would be harmless).

We call "m_extensions->getTranslatedShaderSourceANGLE(shader)", which does it's
own check of the m_shaderSourceMap, and returns an empty string if there is no
shader source entry. We check for the empty string and return prior to hitting
the point where you propose adding a check.

I don't think this change would actually be executed.