[webkit-reviews] review granted: [Bug 126669] Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled : [Attachment 220853] v3

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 126669: Web Inspector: cycle clicked breakpoints between enabled,
auto-continue, and disabled
https://bugs.webkit.org/show_bug.cgi?id=126669

Attachment 220853: v3
https://bugs.webkit.org/attachment.cgi?id=220853&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220853&action=review


r=me

> Source/WebInspectorUI/ChangeLog:31
> +	  
(WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged):
> +	  
(WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged):
> +	   Update the popover height since this could cause additional content
to become visible.

Nit: Stale

> Source/WebInspectorUI/UserInterface/TextEditor.js:1167
> +	       if (this._lineNumberWithMousedDownBreakpoint in
this._breakpoints && this._columnNumberWithMousedDownBreakpoint in
this._breakpoints[this._lineNumberWithMousedDownBreakpoint] &&
delegateImplementsBreakpointClicked)
> +		   this._delegate.textEditorBreakpointClicked(this,
this._lineNumberWithMousedDownBreakpoint,
this._columnNumberWithMousedDownBreakpoint);
>	   }

Do we need to update the TextEditor's this._breakpoints breakpoint info map
which was being done before? Or does that eventually get triggered by
breakpoint modification events (I suspect it does, because what if the
breakpoint was showing in multiple files)?