[webkit-reviews] review granted: [Bug 126737] Clear unparented tiled layers on memory pressure. : [Attachment 220810] Fix style issues.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 126737: Clear unparented tiled layers on memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=126737

Attachment 220810: Fix style issues.
https://bugs.webkit.org/attachment.cgi?id=220810&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220810&action=review


> Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.cpp:68
> +void TileControllerMemoryHandler::trimUnparentedTilesToTarget(unsigned
target)

Use an int for the argument. Surprising things can happen using unsigned math.

> Source/WebCore/platform/ios/TileControllerMemoryHandlerIOS.h:40
> +    void updateForTileController(TileController*);

I think this would be better named tileControllerGainedUnparentedTiles() or
similar.