[webkit-reviews] review denied: [Bug 88188] Accept HTML and MathML namespaces as valid requiredExtensions : [Attachment 220717] Patch V3

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Frédéric Wang <fred.wang at free.fr>'s
request for review:
Bug 88188: Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188

Attachment 220717: Patch V3
https://bugs.webkit.org/attachment.cgi?id=220717&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220717&action=review


Patch looks great, just tiny change requests and the patch is good to go.

> LayoutTests/ChangeLog:5
> +

Please add a detailed description for Changelogs

> Source/WebCore/ChangeLog:12
> +	   When HTML and MathML are used as foreign objects of an SVG image, it
is important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML namespaces as
suggested in SVG Tiny 1.2 and implemented in Gecko.

The description comes right after "Reviewed by..." Please use line breaks.

> Source/WebCore/svg/SVGSwitchElement.cpp:55
> +    // FIXME: The renderer must be updated after dynamic change of the
requiredFeatures, requiredExtensions and systemLanguage attributes
(http://wkbug/74749).

Please change that to http://wkb.ug/74749