[webkit-reviews] review denied: [Bug 125000] [WebGL] Wrong condition order in the if statement : [Attachment 218042] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 125000: [WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000

Attachment 218042: patch
https://bugs.webkit.org/attachment.cgi?id=218042&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218042&action=review


You are right!	Let's clean the change log up slightly and get this landed.

> Source/WebCore/ChangeLog:3
> +	   [WebGL] Wrong condition order in the if statement

[WebGL] Revise condition order for better performance

> Source/WebCore/ChangeLog:12
> +	   this method.

Please Rephrase: We should revise the logic so that we only pay the cost of
string comparison once.  The current logic causes the string comparison to
happen every time we enter this function. Instead, by reordering the statements
we can do a simple boolean test after the initial setup is complete.