[webkit-reviews] review granted: [Bug 126601] [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding in some polygons : [Attachment 220780] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 16:12:11 PST 2014


Bem Jones-Bey <bjonesbe at adobe.com> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 126601: [CSS Shapes] First line gets incorrectly adjusted in shape-inside
due to rounding in some polygons
https://bugs.webkit.org/show_bug.cgi?id=126601

Attachment 220780: Patch
https://bugs.webkit.org/attachment.cgi?id=220780&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220780&action=review


r=me, even if you don't feel like updating for the nit on the test.

>
LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.htm
l:15
> +    background-color: green;

Nit: I'd delete this line.


More information about the webkit-reviews mailing list