[webkit-reviews] review granted: [Bug 126698] [iOS] Upstream WebCore and Tools miscellaneous changes : [Attachment 220748] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 126698: [iOS] Upstream WebCore and Tools miscellaneous changes
https://bugs.webkit.org/show_bug.cgi?id=126698

Attachment 220748: Patch
https://bugs.webkit.org/attachment.cgi?id=220748&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220748&action=review


rs=me.	Please wait to land until build fixes from the previous merge commit
are settled.

> Source/WebCore/Configurations/WebCore.xcconfig:37
> +EXPORTED_SYMBOLS_FILE_ppc64 =
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;

We shouldn't bring back ppc64.

Nit: And we could remove ppc.

> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:29
> +#include <wtf/Platform.h>

I know we include this, but if this is a public header, we should not include
it at all.  Needs to be fixed before the next release.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:833
> +		CE2616AB187E6675007955F3 /* scrub-ifdefs.pl */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.perl; name
= "scrub-ifdefs.pl"; path = "mac/scrub-ifdefs.pl"; sourceTree = "<group>"; };

The scrub-ifdefs.pl script is not needed in open source.  Andy Estes
implemented them differently using the "Postprocess Headers" phase.

All of the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj can be
dropped.

> Source/WebKit/mac/scrub-ifdefs.pl:1
> +#!/usr/bin/perl -w

This whole script does not need to be upstreamed.