[webkit-reviews] review requested: [Bug 126601] [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding in some polygons : [Attachment 220779] Patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 126601: [CSS Shapes] First line gets incorrectly adjusted in shape-inside
due to rounding in some polygons
https://bugs.webkit.org/show_bug.cgi?id=126601

Attachment 220779: Patch
https://bugs.webkit.org/attachment.cgi?id=220779&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #12)
> (From update of attachment 220750 [details])
> Since the color of the text is green, and it's very tiny compared to the
square, it can be hard to tell if this test fails with manual inspection. It
would be nice if you could make the failure mode show some red, for example, by
placing a green div on top of the div with the shape-inside so that you can
make the text red. (and then put "You should not see any red" in the
description)

I increased the size of the content, so it's much bigger now. I also painted to
red and added green overlay. There is no way to miss it now, if it fails. I
also updated the test description.

> > Source/WebCore/rendering/shapes/Shape.h:81
> > +	 virtual bool firstIncludedIntervalLogicalTop(LayoutUnit
minLogicalIntervalTop, const float minLogicalWidth, const LayoutUnit
logicalHeight, LayoutUnit& result) const = 0;
> 
> Why not have this take a FloatSize?

I modified to use FloatSize.

Thanks for looking into.