[webkit-reviews] review granted: [Bug 126654] [iOS] Upstream WebCore/platform changes : [Attachment 220733] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 9 14:40:14 PST 2014
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 126654: [iOS] Upstream WebCore/platform changes
https://bugs.webkit.org/show_bug.cgi?id=126654
Attachment 220733: Patch
https://bugs.webkit.org/attachment.cgi?id=220733&action=review
------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220733&action=review
rs=me. There's no way I could review this whole patch in detail, but I did
glance through all of it.
> Source/WebCore/platform/ScrollTypes.h:29
> +// WTF_PLATFORM_IOS
Nit: This can be removed later. Useless comment at this point.
> Source/WebCore/platform/text/TextCodecICU.cpp:197
> + // A.B. adding a few more Mac encodings missing 'cause we don't have
TextCodecMac right now
A.B. = André Boulé
More information about the webkit-reviews
mailing list