[webkit-reviews] review granted: [Bug 126676] Web Inspector: Correctly track time bounds of WebInspector.Timeline and WebInspector.TimelineRecording : [Attachment 220690] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 126676: Web Inspector: Correctly track time bounds of WebInspector.Timeline
and WebInspector.TimelineRecording
https://bugs.webkit.org/show_bug.cgi?id=126676

Attachment 220690: Patch
https://bugs.webkit.org/attachment.cgi?id=220690&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220690&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:64
> +	       }.bind(this));

You could use the thisObject optional param to Map.prototype.forEach. E.g.:

    forEach(function() {...}, this);

instead of

    forEach(function() {...}.bind(this));

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:74
> +	   }.bind(this));

Ditto