[webkit-reviews] review granted: [Bug 126714] Replace ElementIteratorAdapter find() with beginAt() : [Attachment 220763] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 13:16:00 PST 2014


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 126714: Replace ElementIteratorAdapter find() with beginAt()
https://bugs.webkit.org/show_bug.cgi?id=126714

Attachment 220763: patch
https://bugs.webkit.org/attachment.cgi?id=220763&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220763&action=review


Nice :)

> Source/WebCore/html/HTMLFormElement.cpp:508
> +    if (!associatedHTMLElement.isDescendantOf(this))
> +	   return currentAssociatedElementsAfterIndex;

isDescendantOf signature is rather 2012 :|


More information about the webkit-reviews mailing list