[webkit-reviews] review denied: [Bug 126130] [GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled : [Attachment 220072] Updated patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126130: [GTK] Test /webkit2/WebKitWebContext/languages crashes with network
process enabled
https://bugs.webkit.org/show_bug.cgi?id=126130

Attachment 220072: Updated patch
https://bugs.webkit.org/attachment.cgi?id=220072&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220072&action=review


> Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:80
> +// This function is based on Epiphany code in ephy-embed-prefs.c.
> +static CString buildAcceptLanguages(Vector<String> languages)

Looking around, it seems that ephy-embed-prefs.c is GPL which is a big no-no.
Maybe you can get Xan to relicense it since he seems to be the only copyright
holder.