[webkit-reviews] review granted: [Bug 126681] Correctly fill loaded and total attribute values of XHR ProgressEvent events : [Attachment 220731] Patch 120828 with fix of assertion issues

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 09:27:45 PST 2014


Alexey Proskuryakov <ap at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 126681: Correctly fill loaded and total attribute values of XHR
ProgressEvent events
https://bugs.webkit.org/show_bug.cgi?id=126681

Attachment 220731: Patch 120828 with fix of assertion issues
https://bugs.webkit.org/attachment.cgi?id=220731&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220731&action=review


> Source/WebCore/ChangeLog:8
> +	   Fixed assertions over patch in
https://bugs.webkit.org/show_bug.cgi?id=120828

Looks fine, however the ChangeLog should have a complete explanation, the
discussion of something that was rolled out is confusing.

In other words, I'd just use the same preamble as in the original patch here.


More information about the webkit-reviews mailing list