[webkit-reviews] review granted: [Bug 125156] [MSE][Mac] Report the intrinsic size of the media element : [Attachment 220699] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 125156: [MSE][Mac] Report the intrinsic size of the media element
https://bugs.webkit.org/show_bug.cgi?id=125156

Attachment 220699: Patch
https://bugs.webkit.org/attachment.cgi?id=220699&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220699&action=review


A test case would be useful.

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:331
> +	       auto videoTrack =
VideoTrackPrivateMediaSourceAVFObjC::create(track, this);

This seems like one if the cases where "auto" is not helpful because someone
reading the code can't know what style of ref-ptr
VideoTrackPrivateMediaSourceAVFObjC::create returns.

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:338
> +	       auto audioTrack =
AudioTrackPrivateMediaSourceAVFObjC::create(track, this);

Ditto.