[webkit-reviews] review granted: [Bug 126686] [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2 : [Attachment 220706] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 9 07:06:31 PST 2014
Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126686: [SOUP] Partial file left on disk after a download fails or is
cancelled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126686
Attachment 220706: Patch
https://bugs.webkit.org/attachment.cgi?id=220706&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220706&action=review
> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:313
> +static gboolean writeNextChunkIdle(SoupMessage *message)
> +{
> + soup_message_body_append(message->response_body, SOUP_MEMORY_STATIC,
"chunk", 5);
> + return FALSE;
> +}
> +
> +static void writeNextChunk(SoupMessage *message)
Asterisks are in the wrong place here.
More information about the webkit-reviews
mailing list