[webkit-reviews] review granted: [Bug 122959] [CSSRegions] Move regions auto-size code into RenderNamedFlowFragment : [Attachment 220704] Patch

[bugzilla-daemon at webkit.org]

Mihnea Ovidenie <mihnea at adobe.com> has granted Andrei Bucur
<abucur at adobe.com>'s request for review:
Bug 122959: [CSSRegions] Move regions auto-size code into
RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=122959

Attachment 220704: Patch
https://bugs.webkit.org/attachment.cgi?id=220704&action=review

------- Additional Comments from Mihnea Ovidenie <mihnea at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220704&action=review


r=me, please take a look at the comments before landing.

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:159
> +    ASSERT(newLogicalHeight < LayoutUnit::max() / 2);

I would use RenderFlowThread::maxLogicalHeight() instead of LayoutUnit::max() /
2.

> Source/WebCore/rendering/RenderTreeAsText.cpp:671
> +	       if (isRenderNamedFlowFragment &&
toRenderNamedFlowFragment(renderRegion)->hasAutoLogicalHeight())

Since hasAutoLogicalHeight always returns false for RenderRegion, you can still
use the previous condition.