[webkit-reviews] review denied: [Bug 126541] Margin tiles are not repainted when background color changes : [Attachment 220649] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 126541: Margin tiles are not repainted when background color changes
https://bugs.webkit.org/show_bug.cgi?id=126541

Attachment 220649: Patch
https://bugs.webkit.org/attachment.cgi?id=220649&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220649&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:2097
> +	       FloatRect rectToRepaint = FloatRect(FloatPoint(0, 0),
m_graphicsLayer->size());
> +	       TiledBacking* tiledBacking = this->tiledBacking();
> +	       rectToRepaint.move(-tiledBacking->leftMarginWidth(),
-tiledBacking->topMarginHeight());
> +	       rectToRepaint.expand(tiledBacking->leftMarginWidth() +
tiledBacking->rightMarginWidth(),
> +		   tiledBacking->topMarginHeight() +
tiledBacking->bottomMarginHeight());

I think it would be better to call a function on TiledBacking that inflates the
rect. That way you could eliminate this whole tiledBackingHasMargin()
condition.