[webkit-reviews] review requested: [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore : [Attachment 220657] [PATCH] For Bots 3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 8 13:29:02 PST 2014
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 126598: Web Inspector: Move InjectedScript classes into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126598
Attachment 220657: [PATCH] For Bots 3
https://bugs.webkit.org/attachment.cgi?id=220657&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Use JSC::DestructibleObject. Fixed some style issues.
Note, even with DestructibleObject I don't see the destructor getting called.
And I think there are some memory management issues that I will have to look
into anyways. Continue to investigate.
More information about the webkit-reviews
mailing list