[webkit-reviews] review granted: [Bug 126644] Add WTF::StringView and use it for grammar checking : [Attachment 220646] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 126644: Add WTF::StringView and use it for grammar checking
https://bugs.webkit.org/show_bug.cgi?id=126644

Attachment 220646: Patch
https://bugs.webkit.org/attachment.cgi?id=220646&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=220646&action=review


> Source/WTF/ChangeLog:11
> +	   Add a new StringView class which is an immutable reference to either
an 8-bit or a 16-bit string.
> +
> +	   This makes it easier to pass substrings around without having to
either copy string data
> +	   or upconvert and use UChar pointers.

Might be good to mention std::string_view proposal since the name may be
surprising.

> Source/WTF/wtf/text/StringView.h:36
> +// (This means that strings longer than 2 Gigabytes can not be represented.
If that turns out to be
> +// a problem we can investigate alternative solutions).

Those parentheses seem unnecessary.