[webkit-reviews] review granted: [Bug 126626] Stub for WebSession API : [Attachment 220606] ChangeLog

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Martin Hock <mhock at apple.com>'s request
for review:
Bug 126626: Stub for WebSession API
https://bugs.webkit.org/show_bug.cgi?id=126626

Attachment 220606: ChangeLog
https://bugs.webkit.org/attachment.cgi?id=220606&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220606&action=review


With those changes, r=me.

> Source/WebKit2/UIProcess/API/Cocoa/WKSession.h:26
> +#include <WebKit2/WKSessionRef.h>

This should not be included. It is in some of the objective-c headers as a
temporary renaming mitigation.

> Source/WebKit2/UIProcess/API/Cocoa/WKSession.h:28
> +#ifdef __OBJC__

This is also not needed.

> Source/WebKit2/UIProcess/WebSession.h:37
> +    bool getEphemeral();

This should be called either isEphemeral() or just ephemeral() (I prefer the
isEphemeral()).