[webkit-reviews] review granted: [Bug 20606] a fractional value of the css letter-spacing property is not rendered as expected : [Attachment 220588] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 20606: a fractional value of the css letter-spacing property is not
rendered as expected
https://bugs.webkit.org/show_bug.cgi?id=20606

Attachment 220588: Patch
https://bugs.webkit.org/attachment.cgi?id=220588&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220588&action=review


> Source/WebCore/ChangeLog:9
> +	   It is taken mostly from Blink r153727. Updating the relevant types
is

Some is obviously from iOS too; you should say that.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1220
> +	   new PropertyWrapper<float>(CSSPropertyLetterSpacing,
&RenderStyle::letterSpacing, &RenderStyle::setLetterSpacing),
> +	   new PropertyWrapper<float>(CSSPropertyWordSpacing,
&RenderStyle::wordSpacing, &RenderStyle::setWordSpacing),

This looks the same as the iOS code below.

> Source/WebCore/rendering/style/RenderStyle.h:1666
> +    static float initialLetterWordSpacing() { return 0; }

Very confusing name; please break into two functions.